feat(oauth2): add quickstart, README, etc. #12754
Conversation
This will make the library more usable (I think) by including a quickstart, README, landing page for Doxygen, etc.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12754 +/- ##
=======================================
Coverage 93.60% 93.60%
=======================================
Files 2078 2078
Lines 182456 182456
=======================================
+ Hits 170791 170792 +1
+ Misses 11665 11664 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 18 of 19 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
| @@ -95,7 +97,7 @@ GA_LIBRARIES = GOOGLE_CLOUD_CPP_GA_LIBRARIES | |||
| library_dir = google_cloud_cpp_library_dir_name(library), | |||
| ), | |||
| ], | |||
| ) for library in GA_LIBRARIES + TRANSITION_LIBRARIES] | |||
| ) for library in GA_LIBRARIES + TRANSITION_LIBRARIES if library not in NO_MOCK_LIBRARIES] | |||
There was a problem hiding this comment.
We should probably add this to the experimental-{library}_mocks too.
| @@ -203,7 +203,7 @@ time { | |||
| done | |||
|
|
|||
| mapfile -t libraries < <(features::libraries) | |||
| for library in "${libraries[@]}" opentelemetry; do | |||
| for library in "${libraries[@]}" opentelemetry oauth2; do | |||
There was a problem hiding this comment.
why not add oauth2 to ci/etc/full_feature_list and thus features::libraries() ?
Because it would have to be hardcoded in the generator, and that would be kinda weird?
google-cloud-cpp/generator/standalone_main.cc
Line 179 in 631c00e
There was a problem hiding this comment.
Because I think we should remove ci/etc/full_feature_list in favor of cmake/print-all-libraries.cmake (which does not exist yet)
| function features::list_full() { | ||
| local feature_list | ||
| mapfile -t feature_list < <(features::libraries) | ||
| feature_list+=(opentelemetry experimental-storage_grpc grafeas) |
There was a problem hiding this comment.
FYI: we are dropping grafeas which I am ok with, but it is a feature that does something when we -DGOOGLE_CLOUD_CPP_ENABLE=grafeas. 🤷
and we no longer test it here:
There was a problem hiding this comment.
I am fine with the tradeoff in slightly less testing (the feature is tested indirectly anyway) vs. more manageably CI scripts.
This will make the library more usable (I think) by including a quickstart, README, landing page for Doxygen, etc.
This change is