Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storage): more on InsertObject vs. WriteObject #12577

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Sep 8, 2023

Show that both InsertObject() and WriteObject() can be used to upload data from memory. At least one customer missed the existence of InsertObject() because they thought the example showed all the ways.

Fixed the links showing the tradeoffs between single-shot and resumable-uploads. Be more explicit about what upload type does InsertObject() use.


This change is Reviewable

Show that both `InsertObject()` and `WriteObject()` can be used to
upload data from memory. At least one customer missed the existence of
`InsertObject()` because they thought the example showed **all** the
ways.

Fixed the links showing the tradeoffs between single-shot and
resumable-uploads. Be more explicit about what upload type does
`InsertObject()` use.
@coryan coryan temporarily deployed to internal September 8, 2023 12:27 — with GitHub Actions Inactive
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5a50a04) 93.63% compared to head (7581a8a) 93.63%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12577   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files        2047     2047           
  Lines      181701   181705    +4     
=======================================
+ Hits       170141   170147    +6     
+ Misses      11560    11558    -2     
Files Changed Coverage Δ
google/cloud/storage/client.h 99.84% <ø> (ø)
...e/cloud/storage/examples/storage_object_samples.cc 92.47% <0.00%> (-0.88%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review September 8, 2023 13:12
@coryan coryan requested a review from a team as a code owner September 8, 2023 13:12
google/cloud/storage/client.h Outdated Show resolved Hide resolved
@coryan coryan temporarily deployed to internal September 8, 2023 13:29 — with GitHub Actions Inactive
@coryan coryan enabled auto-merge (squash) September 8, 2023 13:33
@coryan coryan merged commit 3c7262f into googleapis:main Sep 8, 2023
@coryan coryan deleted the docs-storage-fix-object-size-references branch September 8, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants