Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): change url_encode include from .h to .cc #12547

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Sep 5, 2023

Part of #12232


This change is Reviewable

@alevenberg alevenberg requested a review from a team as a code owner September 5, 2023 18:56
@alevenberg alevenberg temporarily deployed to internal September 5, 2023 18:56 — with GitHub Actions Inactive
@alevenberg alevenberg changed the title fix: change url_encode include from .h to .cc fix(internal): change url_encode include from .h to .cc Sep 5, 2023
@alevenberg alevenberg temporarily deployed to internal September 5, 2023 19:23 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (6e9d901) 93.64% compared to head (2e760b2) 93.63%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12547      +/-   ##
==========================================
- Coverage   93.64%   93.63%   -0.01%     
==========================================
  Files        2044     2044              
  Lines      181278   181278              
==========================================
- Hits       169750   169744       -6     
- Misses      11528    11534       +6     
Files Changed Coverage Δ
...internal/golden_kitchen_sink_metadata_decorator.cc 84.31% <ø> (ø)
.../internal/golden_kitchen_sink_metadata_decorator.h 100.00% <ø> (ø)
.../internal/golden_thing_admin_metadata_decorator.cc 92.02% <ø> (ø)
...1/internal/golden_thing_admin_metadata_decorator.h 100.00% <ø> (ø)
generator/internal/metadata_decorator_generator.cc 34.54% <100.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan changed the title fix(internal): change url_encode include from .h to .cc fix(internal): change url_encode include from .h to .cc Sep 5, 2023
@alevenberg alevenberg merged commit 555586f into googleapis:main Sep 5, 2023
@alevenberg alevenberg deleted the quick-fix branch September 5, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants