Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): retry loops preserve original message #12368

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Aug 10, 2023

Some applications want to have access to the original message, even after a retry failure.


This change is Reviewable

Some applications want to have access to the original message, even
after a retry failure.
@coryan coryan temporarily deployed to internal August 10, 2023 23:30 — with GitHub Actions Inactive
@coryan coryan marked this pull request as ready for review August 10, 2023 23:48
@coryan coryan requested a review from a team as a code owner August 10, 2023 23:48
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (45f5346) 93.61% compared to head (70a0c86) 93.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12368   +/-   ##
=======================================
  Coverage   93.61%   93.61%           
=======================================
  Files        2029     2029           
  Lines      179812   179847   +35     
=======================================
+ Hits       168333   168371   +38     
+ Misses      11479    11476    -3     
Files Changed Coverage Δ
...oogle/cloud/internal/async_rest_retry_loop_test.cc 98.62% <100.00%> (+0.01%) ⬆️
google/cloud/internal/async_retry_loop_test.cc 98.86% <100.00%> (+0.01%) ⬆️
google/cloud/internal/rest_retry_loop_test.cc 98.39% <100.00%> (+0.05%) ⬆️
google/cloud/internal/retry_loop_helpers.cc 100.00% <100.00%> (ø)
google/cloud/internal/retry_loop_helpers_test.cc 100.00% <100.00%> (ø)
google/cloud/internal/retry_loop_test.cc 97.72% <100.00%> (+0.08%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

This makes me wonder if we even want to manipulate the status message. We could leave the retry information as error info metadata only.

I am sure there are customers who << status.message() instead of << status, though.

@coryan coryan merged commit 3a20210 into googleapis:main Aug 11, 2023
@coryan coryan deleted the feat-common-retry-loops-preserve-original-error-message branch August 11, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants