fix(storage): tracing should decorate retries #12314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #12314 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 2017 2017
Lines 178384 178411 +27
=======================================
+ Hits 166866 166896 +30
+ Misses 11518 11515 -3
☔ View full report in Codecov by Sentry. |
devbww
approved these changes
Aug 4, 2023
google/cloud/storage/client_test.cc
Outdated
| .set<UnifiedCredentialsOption>(MakeInsecureCredentials()) | ||
| .set<internal::UseRestClientOption>(true) | ||
| .set<TracingComponentsOption>({"raw-client"}); | ||
| #ifdef GOOGLE_CLOUD_CPP_HAVE_OPENTELEMETRY |
There was a problem hiding this comment.
This can be unconditional, no?
There was a problem hiding this comment.
Sadly not at the moment, the option is inside a #ifdef block. Created #12316
There was a problem hiding this comment.
You know, I carefully went off and read the header before making the comment, and still missed the conditionals. Sigh.
devbww
approved these changes
Aug 4, 2023
dbolduc
reviewed
Aug 4, 2023
2c77f95 to
aa28782
Compare
dbolduc
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #12294
This change is