Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(spanner): add documentation/sample for TransactionRerunPolicy #12140

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Jul 18, 2023

Documentation for the TransactionRerunPolicy and its two, supplied implementations, the LimitedErrorCountTransactionRerunPolicy and the LimitedTimeTransactionRerunPolicy. Link to the "commit-with-policies" snippet. Fixes #11269.

Also separate the "spanner-retry-policies" documentation into its own .dox file, expanding the treatment of spanner::RetryPolicy and spanner::BackoffPolicy in the process.


This change is Reviewable

Documentation for the `TransactionRerunPolicy` and its two, supplied
implementations, the `LimitedErrorCountTransactionRerunPolicy` and the
`LimitedTimeTransactionRerunPolicy`.  Link to the "commit-with-policies"
snippet.  Fixes googleapis#11269.

Also separate the "spanner-retry-policies" documentation into its
own `.dox` file, expanding the treatment of `spanner::RetryPolicy`
and `spanner::BackoffPolicy` in the process.
@devbww devbww temporarily deployed to internal July 18, 2023 17:53 — with GitHub Actions Inactive
@product-auto-label product-auto-label bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (310212d) 93.58% compared to head (1b5451b) 93.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12140   +/-   ##
=======================================
  Coverage   93.58%   93.59%           
=======================================
  Files        2012     2012           
  Lines      176074   176074           
=======================================
+ Hits       164785   164790    +5     
+ Misses      11289    11284    -5     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devbww devbww temporarily deployed to internal July 18, 2023 18:37 — with GitHub Actions Inactive
@devbww devbww marked this pull request as ready for review July 18, 2023 18:42
@devbww devbww requested a review from a team as a code owner July 18, 2023 18:42
@devbww devbww merged commit 340772e into googleapis:main Jul 18, 2023
@devbww devbww deleted the spanner-policy-override branch July 18, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spanner policies for commit
2 participants