fix(common): avoid run-time conflicts on Windows #12105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The best explanation I found is in: confluentinc/librdkafka#3554 (comment) Basically using the `FILE*` variants of OpenSSL functions requires linking to the same MSVC runtime as the OpenSSL DLL, that can be tricky to figure out. Using the `BIO*` variants does not have the problem.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #12105 +/- ##
=======================================
Coverage 93.68% 93.68%
=======================================
Files 2012 2012
Lines 175732 175729 -3
=======================================
- Hits 164635 164633 -2
+ Misses 11097 11096 -1
☔ View full report in Codecov by Sentry. |
devbww
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The best explanation I found is in:
confluentinc/librdkafka#3554 (comment)
Basically using the
FILE*variants of OpenSSL functions requires linking to the same MSVC runtime as the OpenSSL DLL, that can be tricky to figure out. Using theBIO*variants does not have the problem.This change is