feat(spanner): make ResultSourceInterface public
#11636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class is needed to mock some operations in `spanner::Client`. Application developers may need to refer to its functions, and it needs to be documented so people know what the mock should do.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #11636 +/- ##
=======================================
Coverage ? 93.78%
=======================================
Files ? 1824
Lines ? 164394
Branches ? 0
=======================================
Hits ? 154179
Misses ? 10215
Partials ? 0
☔ View full report in Codecov by Sentry. |
devbww
reviewed
May 17, 2023
google/cloud/spanner/results.h
Outdated
Comment on lines
49
to
50
| * @return if the stream is interrupted due to a failure the | ||
| * `StatusOr<spanner::Row>` contains the error. If the |
google/cloud/spanner/results.h
Outdated
| virtual absl::optional<google::spanner::v1::ResultSetMetadata> Metadata() = 0; | ||
|
|
||
| /** | ||
| * Returns statiscs about the result set, such as the number of rows returned, |
google/cloud/spanner/results.h
Outdated
| virtual absl::optional<google::spanner::v1::ResultSetMetadata> Metadata() = 0; | ||
|
|
||
| /** | ||
| * Returns statiscs about the result set, such as the number of rows returned, |
There was a problem hiding this comment.
s/rows returned/rows/ perhaps?
google/cloud/spanner/results.h
Outdated
|
|
||
| /** | ||
| * Returns statiscs about the result set, such as the number of rows returned, | ||
| * or the query plan used to compute the results. |
devbww
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class is needed to mock some operations in
spanner::Client. Application developers may need to refer to its functions, and it needs to be documented so people know what the mock should do.Motivated by #11430
This change is