doc(bigtable): deprecate DataClient in doxygen #11550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11550 +/- ##
==========================================
- Coverage 93.79% 93.79% -0.01%
==========================================
Files 1816 1816
Lines 163437 163437
==========================================
- Hits 153292 153290 -2
- Misses 10145 10147 +2
☔ View full report in Codecov by Sentry. |
devbww
approved these changes
May 10, 2023
alevenberg
pushed a commit
to alevenberg/google-cloud-cpp
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks the
class DataClientandTable::Table(std::shared_ptr<DataClient>, ...)ctors as deprecated. This is in doxygen only. There are no compiler warnings emitted.Also, move these deprecated constructors to the bottom of the header, so that they show up later in our documentation.
(Yes, my PR is doing two things at once. I split it into two commits for the sake of reviewability)
This change is