Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigtable): retries for CheckConsistency / AsyncWaitForConsistency #10955

Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Feb 25, 2023

Part of the work for #10413

Default BigtableTableAdmin::(Async)CheckConsistency to be idempotent. This will improve the success rate for the bigtable_admin::AsyncWaitForConsistency(...) helper.

This probably "fixes" #9870. Getting UNAVAILABLE is a fairly common flake when run against production in our CI.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Feb 25, 2023
@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Base: 93.64% // Head: 93.64% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (82a3512) compared to base (9ee0d20).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10955   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files        1717     1717           
  Lines      154915   154915           
=======================================
+ Hits       145070   145071    +1     
+ Misses       9845     9844    -1     
Impacted Files Coverage Δ
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 84.21% <0.00%> (-0.66%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 88.62% <0.00%> (-0.34%) ⬇️
google/cloud/pubsub/samples/samples.cc 86.94% <0.00%> (-0.08%) ⬇️
google/cloud/storage/parallel_upload.cc 98.62% <0.00%> (+0.34%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.49% <0.00%> (+0.50%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc marked this pull request as ready for review February 25, 2023 23:53
@dbolduc dbolduc requested a review from a team as a code owner February 25, 2023 23:53
@dbolduc dbolduc merged commit a471a6e into googleapis:main Feb 26, 2023
@dbolduc dbolduc deleted the bigtable-check-consistency-idempotent branch February 26, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants