Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): no warnings on ack()/nack() success #10920

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 22, 2023

Fixes #10921


This change is Reviewable

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Feb 22, 2023
@coryan coryan marked this pull request as ready for review February 22, 2023 14:12
@coryan coryan requested a review from a team as a code owner February 22, 2023 14:12
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 93.64% // Head: 93.65% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7c598dd) compared to base (1f13831).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10920   +/-   ##
=======================================
  Coverage   93.64%   93.65%           
=======================================
  Files        1717     1717           
  Lines      154743   154762   +19     
=======================================
+ Hits       144914   144940   +26     
+ Misses       9829     9822    -7     
Impacted Files Coverage Δ
...oogle/cloud/pubsub/internal/ack_handler_wrapper.cc 100.00% <100.00%> (ø)
.../cloud/pubsub/internal/ack_handler_wrapper_test.cc 100.00% <100.00%> (ø)
google/cloud/internal/timer_queue.cc 96.10% <0.00%> (-1.30%) ⬇️
google/cloud/storage/parallel_upload.cc 98.28% <0.00%> (-0.35%) ⬇️
google/cloud/pubsub/samples/samples.cc 87.01% <0.00%> (+0.07%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 89.29% <0.00%> (+0.33%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.66% <0.00%> (+0.83%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan merged commit 9991ec9 into googleapis:main Feb 22, 2023
@coryan coryan deleted the fix-pubsub-no-warnings-on-success branch February 22, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spurious warning in pubsub AckHandler
2 participants