refactor(generator): split DescriptorPoolFixture #10676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolduc
approved these changes
Jan 27, 2023
| * | ||
| * TEST_F(MyTest, Name) { | ||
| * ASSERT_TRUE(AddProtoFile("foo.proto", contents)); | ||
| * } |
| /** | ||
| * Implements a fixture for test using a `google::protobuf::DescriptorPool`. | ||
| * | ||
| * Some test need a properly initialized descriptor pool, with: |
| * | ||
| * Some test need a properly initialized descriptor pool, with: | ||
| * - the basic protobuf types and options already available | ||
| * - connected to error collectors so the test fails with meaningful errors |
| namespace generator_testing { | ||
|
|
||
| /** | ||
| * Implements a fixture for test using a `google::protobuf::DescriptorPool`. |
There was a problem hiding this comment.
optional: s/test using/testing with/ ?
Codecov ReportBase: 93.71% // Head: 93.70% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10676 +/- ##
==========================================
- Coverage 93.71% 93.70% -0.01%
==========================================
Files 1692 1695 +3
Lines 152774 152786 +12
==========================================
+ Hits 143170 143174 +4
- Misses 9604 9612 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #7664
This change is