Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(generator): split *ErrorCollector #10675

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jan 27, 2023

Part of the work for #7664


This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 93.73% // Head: 93.74% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (757e29c) compared to base (e773e4e).
Patch coverage: 45.45% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10675      +/-   ##
==========================================
+ Coverage   93.73%   93.74%   +0.01%     
==========================================
  Files        1688     1690       +2     
  Lines      152699   152679      -20     
==========================================
  Hits       143135   143135              
+ Misses       9564     9544      -20     
Impacted Files Coverage Δ
generator/generator_test.cc 100.00% <ø> (+5.63%) ⬆️
generator/internal/predicate_utils_test.cc 100.00% <ø> (+1.15%) ⬆️
generator/testing/error_collectors.cc 0.00% <0.00%> (ø)
generator/internal/descriptor_utils_test.cc 99.01% <100.00%> (+1.27%) ⬆️
...erator/internal/resolve_comment_references_test.cc 100.00% <100.00%> (+13.20%) ⬆️
generator/internal/service_code_generator_test.cc 99.29% <100.00%> (+1.37%) ⬆️
generator/testing/error_collectors.h 100.00% <100.00%> (ø)
google/cloud/pubsub/subscriber_connection_test.cc 100.00% <0.00%> (+1.21%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review January 27, 2023 15:36
@coryan coryan requested a review from a team as a code owner January 27, 2023 15:36
@coryan coryan merged commit 03b3df7 into googleapis:main Jan 27, 2023
@coryan coryan deleted the refactor-generator-split-error-collector branch January 27, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants