Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): missing Abseil deps in pkgconfig #10616

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jan 19, 2023

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 94.03% // Head: 94.03% // No change to project coverage 👍

Coverage data is based on head (f2d55b2) compared to base (423bfc6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10616   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files        1669     1669           
  Lines      149593   149593           
=======================================
  Hits       140664   140664           
  Misses       8929     8929           
Impacted Files Coverage Δ
google/cloud/internal/async_rpc_details.h 95.00% <0.00%> (-5.00%) ⬇️
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 84.21% <0.00%> (-0.66%) ⬇️
...torage/examples/storage_service_account_samples.cc 97.63% <0.00%> (-0.60%) ⬇️
google/cloud/pubsub/samples/samples.cc 87.99% <0.00%> (+0.07%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.49% <0.00%> (+0.33%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 89.63% <0.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review January 19, 2023 19:33
@coryan coryan requested a review from a team as a code owner January 19, 2023 19:33
@coryan coryan enabled auto-merge (squash) January 19, 2023 19:34
@coryan coryan merged commit 044f41d into googleapis:main Jan 19, 2023
@coryan coryan deleted the fix-add-missing-absl-deps branch January 19, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants