-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(bigtable): create page for configuration options #10197
doc(bigtable): create page for configuration options #10197
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.98% // Head: 93.97% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10197 +/- ##
==========================================
- Coverage 93.98% 93.97% -0.01%
==========================================
Files 1531 1531
Lines 141068 141068
==========================================
- Hits 132584 132573 -11
- Misses 8484 8495 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be adding the OptionList<>
s? Have they fallen out of favor?
* Option to configure the retry policy used by `Table`. | ||
* | ||
* @ingroup bigtable-options | ||
*/ | ||
struct DataRetryPolicyOption { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
every generated service has an equivalent of this option too. Will they all get these *-options.dox
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to, yes, but I did the hand-crafted libraries first.
I am not sure why customers would care for them. AFAIK they are only used to implement some checks, and probably should not be in the public namespace. I have no idea if we should remove them, move them to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. I think the OptionList<>
s were also added for discoverability of Options.
google-cloud-cpp/google/cloud/accessapproval/access_approval_connection.h
Lines 118 to 125 in 3baceac
* The optional @p options argument may be used to configure aspects of the | |
* returned `AccessApprovalConnection`. Expected options are any of the types in | |
* the following option lists: | |
* | |
* - `google::cloud::CommonOptionList` | |
* - `google::cloud::GrpcOptionList` | |
* - `google::cloud::UnifiedCredentialsOptionList` | |
* - `google::cloud::accessapproval::AccessApprovalPolicyOptionList` |
But these doxygen ref groups probably do a better job.
This change is