feat(spanner): add support for RowStream::RowsModified() #10102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soon it will be possible for `Client::ExecuteQuery()` to execute a DML statement (within a read/write transaction) that both modifies and returns data. So, if the result source behind the `RowStream` can produce `ResultSetStats`, we can return the number of rows that were modified. Otherwise, for a normal query, return zero.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.96% // Head: 93.96% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10102 +/- ##
==========================================
- Coverage 93.96% 93.96% -0.01%
==========================================
Files 1513 1513
Lines 139824 139837 +13
==========================================
+ Hits 131391 131399 +8
- Misses 8433 8438 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
coryan
approved these changes
Oct 26, 2022
devbww
added a commit
to devbww/google-cloud-cpp
that referenced
this pull request
Nov 11, 2022
Add tests and samples for GOOGLE_STANDARD_SQL "THEN RETURN" and POSTGRESQL "RETURNING". Note that `Client::ExecuteQuery()` can now execute a DML statement with a returning clause. Previously we added support for `RowStream::RowsModified()` (googleapis#10102), which is now used here.
devbww
added a commit
that referenced
this pull request
Nov 11, 2022
Add tests and samples for GOOGLE_STANDARD_SQL "THEN RETURN" and POSTGRESQL "RETURNING". Note that `Client::ExecuteQuery()` can now execute a DML statement with a returning clause. Previously we added support for `RowStream::RowsModified()` (#10102), which is now used here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soon it will be possible for
Client::ExecuteQuery()to execute a DML statement (within a read/write transaction) that both modifies and returns data. So, if the result source behind theRowStreamcan produceResultSetStats, we can return the number of rows that were modified. Otherwise, for a normal query, return zero.This change is