Address review comments and rebase

googleapis · Jul 11, 2023 · d081031 · d081031
1 parent eea788a
commit d081031
Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/ci/cloudbuild/builds/check-api.sh b/ci/cloudbuild/builds/check-api.sh
@@ -39,7 +39,7 @@ io::run cmake "${cmake_args[@]}" \
   -DGOOGLE_CLOUD_CPP_ENABLE="${ENABLED_FEATURES}" \
   -DCMAKE_CXX_FLAGS="-Og -Wno-maybe-uninitialized"
 io::run cmake --build cmake-out
-io::run cmake --install cmake-out #>/dev/null
+io::run cmake --install cmake-out >/dev/null
 
 if [ "${GOOGLE_CLOUD_CPP_CHECK_API:-}" ]; then
   IFS=',' read -ra library_list <<<"${GOOGLE_CLOUD_CPP_CHECK_API}"

diff --git a/google/cloud/access_token_generator.cc b/google/cloud/access_token_generator.cc
@@ -23,22 +23,23 @@ namespace {
 class AccessTokenGeneratorImpl : public AccessTokenGenerator {
  public:
   explicit AccessTokenGeneratorImpl(
-      std::shared_ptr<google::cloud::oauth2_internal::Credentials> impl)
-      : impl_(std::move(impl)) {}
+      std::shared_ptr<google::cloud::oauth2_internal::Credentials> creds)
+      : creds_(std::move(creds)) {}
   ~AccessTokenGeneratorImpl() override = default;
 
   StatusOr<AccessToken> GetToken() override {
-    return impl_->GetToken(std::chrono::system_clock::now());
+    return creds_->GetToken(std::chrono::system_clock::now());
   }
 
  private:
-  std::shared_ptr<google::cloud::oauth2_internal::Credentials> impl_;
+  std::shared_ptr<google::cloud::oauth2_internal::Credentials> creds_;
 };
 
 }  // namespace
 
 std::shared_ptr<AccessTokenGenerator> MakeAccessTokenGenerator(
-    std::shared_ptr<Credentials> credentials) {  // NOLINT
+    // NOLINTNEXTLINE(performance-unnecessary-value-param)
+    std::shared_ptr<Credentials> credentials) {
   return std::make_shared<AccessTokenGeneratorImpl>(
       rest_internal::MapCredentials(credentials));
 }