test(spanner): RestoreDatabase() now sets database_dialect (#9549)

Fixes #8573.
googleapis · Jul 22, 2022 · c03a1e9 · c03a1e9
1 parent 8fdbb22
commit c03a1e9
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 15 deletions.
diff --git a/google/cloud/spanner/admin/integration_tests/backup_extra_integration_test.cc b/google/cloud/spanner/admin/integration_tests/backup_extra_integration_test.cc
@@ -494,13 +494,6 @@ TEST_F(BackupExtraIntegrationTest, BackupRestoreWithCMEK) {
     EXPECT_EQ(restored_database->encryption_config().kms_key_name(),
               encryption_key.FullName());
   }
-  if (restored_database->database_dialect() ==
-      google::spanner::admin::database::v1::DatabaseDialect::
-          DATABASE_DIALECT_UNSPECIFIED) {
-    // TODO(#8573): Remove when RestoreDatabase() returns correct dialect.
-    restored_database->set_database_dialect(
-        google::spanner::admin::database::v1::DatabaseDialect::POSTGRESQL);
-  }
   EXPECT_EQ(restored_database->database_dialect(),
             database->database_dialect());
 

diff --git a/google/cloud/spanner/admin/integration_tests/backup_integration_test.cc b/google/cloud/spanner/admin/integration_tests/backup_integration_test.cc
@@ -195,14 +195,6 @@ TEST_F(BackupIntegrationTest, BackupRestore) {
   EXPECT_STATUS_OK(restored_database);
   if (restored_database) {
     EXPECT_EQ(restored_database->name(), restore_db.FullName());
-    if (restored_database->database_dialect() ==
-        google::spanner::admin::database::v1::DatabaseDialect::
-            DATABASE_DIALECT_UNSPECIFIED) {
-      // TODO(#8573): Remove when RestoreDatabase() returns correct dialect.
-      restored_database->set_database_dialect(
-          google::spanner::admin::database::v1::DatabaseDialect::
-              GOOGLE_STANDARD_SQL);
-    }
     EXPECT_EQ(restored_database->database_dialect(),
               database->database_dialect());