different approach

googleapis · Dec 4, 2024 · a9091ee · a9091ee
1 parent 1dd89ad
commit a9091ee
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/ci/gha/builds/windows-cmake.sh b/ci/gha/builds/windows-cmake.sh
@@ -52,8 +52,6 @@ fi
 # [2]: https://stackoverflow.com/questions/3775406
 args+=("-DCMAKE_EXE_LINKER_FLAGS=/MANIFEST:NO")
 
-args+=("-DCMAKE_CXX_FLAGS= /wd4996")
-
 io::log_h1 "Starting Build"
 TIMEFORMAT="==> 🕑 CMake configuration done in %R seconds"
 time {

diff --git a/cmake/GoogleCloudCppCommonOptions.cmake b/cmake/GoogleCloudCppCommonOptions.cmake
@@ -80,6 +80,7 @@ function (google_cloud_cpp_add_common_options target)
             return()
         endif ()
         target_compile_options(${target} PRIVATE "/W3")
+        target_compile_options(${target} PRIVATE "/wd4996")
         if (GOOGLE_CLOUD_CPP_ENABLE_WERROR)
             target_compile_options(${target} PRIVATE "/WX")
         endif ()

diff --git a/google/cloud/bigtable/test_proxy/BUILD.bazel b/google/cloud/bigtable/test_proxy/BUILD.bazel
@@ -22,7 +22,6 @@ cc_library(
     testonly = True,
     srcs = ["cbt_test_proxy.cc"],
     hdrs = ["cbt_test_proxy.h"],
-    copts = ["-Wno-deprecated-declarations"],
     deps = [
         "//:bigtable",
         "//protos:system_includes",