Skip to content

Commit

Permalink
address bww comments
Browse files Browse the repository at this point in the history
  • Loading branch information
alevenberg committed Nov 3, 2023
1 parent e55b5a3 commit 4f94155
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions google/cloud/pubsub/internal/tracing_message_batch.cc
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ auto MakeLinks(Spans::const_iterator begin, Spans::const_iterator end) {

auto MakeParent(Links const& links, Spans const& message_spans) {
namespace sc = ::opentelemetry::trace::SemanticConventions;
// // Detach current otel context before creating the span.
// Detach current otel context before creating the span.
internal::DetachOTelContext(
opentelemetry::context::RuntimeContext::GetCurrent());
auto batch_sink_parent =
Expand Down Expand Up @@ -155,7 +155,7 @@ class TracingMessageBatch : public MessageBatch {
// the vector.
auto scope =
std::make_shared<internal::OTelScope>(batch_sink_spans.front());
// You must capture the scope, so it stays alive until the callback function
// Capture the scope so it stays alive the returned function
// is called.
return [scope = std::move(scope),
oc = opentelemetry::context::RuntimeContext::GetCurrent(),
Expand Down

0 comments on commit 4f94155

Please sign in to comment.