address comments; disable rest tests versus emulator

googleapis · Sep 5, 2024 · 15fb48e · 15fb48e
1 parent d0618c9
commit 15fb48e
Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/google/cloud/spanner/admin/integration_tests/instance_admin_rest_integration_test.cc b/google/cloud/spanner/admin/integration_tests/instance_admin_rest_integration_test.cc
@@ -153,6 +153,8 @@ class InstanceAdminClientRestTest
  protected:
   void SetUp() override {
     if (Emulator()) {
+      // TODO(#14679): Remove this GTEST_SKIP when emulator supports editions.
+      GTEST_SKIP();
       // We expect test instances to exist when running against real services,
       // but if we are running against the emulator we're happy to create one.
       Instance in(ProjectId(), InstanceId());

diff --git a/google/cloud/spanner/create_instance_request_builder.h b/google/cloud/spanner/create_instance_request_builder.h
@@ -117,7 +117,9 @@ class CreateInstanceRequestBuilder {
     return std::move(*this);
   }
 
-  enum class Edition { kStandard = 0, kEnterprise, kEnterprisePlus };
+  // Available editions.
+  // https://cloud.google.com/spanner/docs/editions-overview
+  enum class Edition { kStandard, kEnterprise, kEnterprisePlus };
 
   CreateInstanceRequestBuilder& SetEdition(Edition edition) & {
     switch (edition) {