chore: Fix new rubocop warnings #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
x ? true : falseidiom is now getting flagged by rubocop underStyle/RedundantCondition. I would argue this is a false positive, but I don't have confidence that is a popular enough opinion to cause rubocop to revert its behavior. In any case, we can avoid the problem by making the change in this PR. This does change the internal functionality, as@universe_domain_overriddenis now merely truthy/falsey rather than strictlytrueorfalse. However, it should only get used internally (in a context where we don't care about the strict type), so that shouldn't matter.