Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: install package before tests deps in unit_prev_versions #703

Merged
merged 2 commits into from
Feb 16, 2021
Merged

test: install package before tests deps in unit_prev_versions #703

merged 2 commits into from
Feb 16, 2021

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Feb 16, 2021 •
edited
Loading

One of the test dependencies appears to require rsa, which resulted in a rsa version incompatible with 2.7 being installed.

Switching the order resolves the issue (rsa is installed according to the requirements in setup.py)

google-auth-library-python/setup.py

Lines 24 to 27 in aeab5d0

# rsa==4.5 is the last version to support 2.7
# https://github.com/sybrenstuvel/python-rsa/issues/152#issuecomment-643470233
'rsa<4.6; python_version < "3.6"',
'rsa>=3.1.4,<5; python_version >= "3.6"',

@busunkim96 busunkim96 requested a review from a team as a code owner February 16, 2021 18:51
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 16, 2021
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Feb 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 882d0ff into master Feb 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-unit-prev-tests branch February 16, 2021 20:10
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 16, 2021
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@busunkim96 @arithmetic1728