Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docstring of to_json method #495

Closed
wants to merge 2 commits into from
Closed

update docstring of to_json method #495

wants to merge 2 commits into from

Conversation

alvyjudy
Copy link
Contributor

@alvyjudy alvyjudy commented May 4, 2020 •
edited
Loading

from #494
The original docstring of to_json referenced a method called from_json which actually exists in the form of from_authorized_user_info. I also added some explanation for the functionality provided by from_authorized_user_info.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2020
@alvyjudy alvyjudy closed this May 4, 2020
@alvyjudy alvyjudy reopened this May 4, 2020
@adelevie
Copy link

adelevie commented May 5, 2020

One minor thing, maybe worth pointing out, is to_json returns a string, while from_authorized_user_info expects a dictionary.

@alvyjudy
Copy link
Contributor Author

alvyjudy commented May 6, 2020

I might have messed up a few commit messages and formatting so I'll just close this and make another one:(

@alvyjudy alvyjudy closed this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvyjudy @adelevie @googlebot