Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multi universe support, adding universe_domain field #1282
feat: multi universe support, adding universe_domain field #1282
Changes from all commits
4ddad12
c41f542
3957bd0
41de188
efe23b1
090674f
3eb4047
da7e1b7
72e4dd0
c192155
35f79d0
0749124
763f6b0
309312d
c63ed36
3b46e38
bc2360f
482603f
0c21a72
4b21ca2
bab1ccc
a009715
de8c400
9659e40
1bc4d3f
c671f0d
64b9d0a
bc51410
a4c4a09
439b486
69c966e
18e1429
8c21b7e
eceba5a
bfbd4fc
6a3b81c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deprecate this constructor in favor of the builder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot to deprecate it?