Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add dependencies(17) as the only required dependencies check #1260

Merged
merged 2 commits into from
Jul 25, 2023
Merged

chore: Add dependencies(17) as the only required dependencies check #1260

merged 2 commits into from
Jul 25, 2023

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Jul 25, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

This is keep in compliance with: googleapis/synthtool#1800

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 25, 2023
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/sync-repo-settings.yaml

@lqiu96 lqiu96 marked this pull request as ready for review July 25, 2023 20:41
@lqiu96 lqiu96 requested review from a team as code owners July 25, 2023 20:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lqiu96 lqiu96 merged commit c6b747b into main Jul 25, 2023
@lqiu96 lqiu96 deleted the update-required-checks branch July 25, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lqiu96 @blakeli0