feat: support GoogleAuth parameter #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Auth client or API Key for the request | ||
| */ | ||
| auth?: |
There was a problem hiding this comment.
nit, but still: the keys were sorted here, maybe auth can go below alt? :)
There was a problem hiding this comment.
All of those standard parameters are actually generated from the discovery file. This would be silly hard :/
alexander-fenster
approved these changes
Jun 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #2210 +/- ##
==========================================
- Coverage 84.14% 84.08% -0.07%
==========================================
Files 9 9
Lines 1602 1602
Branches 114 112 -2
==========================================
- Hits 1348 1347 -1
- Misses 254 255 +1
Continue to review full report at Codecov.
|
This was referenced Jan 12, 2022
This was referenced Feb 10, 2022
This was referenced Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change requires googleapis/nodejs-googleapis-common#287 to land before going out. It does a few things:
GoogleAuthparameter. Anything that has arequestmethod with the right signature.authinto theStandardParametersinterface instead of stamping it out every time in each individual generated interface.