Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

fix: properly delete branch by git reference #139

Merged
merged 2 commits into from
Sep 4, 2018
Merged

fix: properly delete branch by git reference #139

merged 2 commits into from
Sep 4, 2018

Conversation

alexander-fenster
Copy link
Contributor

Fixes #138. Branch deletion uses Git References API and requires a fully qualified reference e.g. refs/heads/branch-name to be passed, not just branch-name.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 4, 2018
@alexander-fenster alexander-fenster merged commit 7c8921a into master Sep 4, 2018
@alexander-fenster alexander-fenster deleted the alexander-fenster-patch-1 branch September 4, 2018 21:02
@alexander-fenster alexander-fenster mentioned this pull request Sep 18, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@jkwlui jkwlui Awaiting requested review from jkwlui

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-fenster @JustinBeckwith @googlebot