Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

feat: make repo exec async #111

Merged
merged 5 commits into from
Jul 31, 2018
Merged

feat: make repo exec async #111

merged 5 commits into from
Jul 31, 2018

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@JustinBeckwith JustinBeckwith requested a review from a team July 30, 2018 03:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 30, 2018
src/sync.ts Outdated
return spawn(command.join(' '), {cwd: dir})
.then(r => {
i++;
logger.info(`[${i}/${dirs.length}] Executing cmd in ${dir}...`);

This comment was marked as spam.

This comment was marked as spam.

}
}
let i = 0;
const q = new Q({concurrency: 10});

This comment was marked as spam.

This comment was marked as spam.

Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gts fix fails, plus two minor comments.

@jkwlui jkwlui self-requested a review July 30, 2018 21:01
@codecov-io
Copy link

codecov-io commented Jul 30, 2018

Codecov Report

Merging #111 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   94.07%   94.07%           
=======================================
  Files          12       12           
  Lines         995      995           
  Branches       60       60           
=======================================
  Hits          936      936           
  Misses         40       40           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5795d68...eabe11c. Read the comment docs.

@JustinBeckwith
Copy link
Contributor Author

@alexander-fenster mind taking another look?

Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alexander-fenster alexander-fenster merged commit 6945d68 into googleapis:master Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants