-
Notifications
You must be signed in to change notification settings - Fork 39
Conversation
Can we not do this and set up a kokoro job instead?
…On Fri, Jul 27, 2018, 3:38 PM Justin Beckwith ***@***.***> wrote:
@JustinBeckwith <https://github.com/JustinBeckwith> requested your review
on: googleapis/github-repo-automation#109
<#109> chore:
use CircleCI for publish.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#109 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUc16S17pVy9cLvCfYyflVNLQuGFAvks5uK5Z4gaJpZM4Vkwhp>
.
|
.circleci/config.yml
Outdated
|
||
branches: | ||
ignore: /.*/ | ||
tags: *releases |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
=======================================
Coverage 94.45% 94.45%
=======================================
Files 12 12
Lines 991 991
Branches 60 60
=======================================
Hits 936 936
Misses 36 36
Partials 19 19 Continue to review full report at Codecov.
|
- run: | ||
name: Build documentation. | ||
command: npm run docs | ||
- run: echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sure! Do you want to take a shot, or should we wait for you to pair up with @kinwa91? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theacodes I'm approving Justin's change for now but I totally support trying Kokoro - we can switch to using it for releasing when it's ready.
It's been ready. We have extensive docs on the dpe team site for setting up
kokoro. I'm happy to review and help if folks get stuck.
…On Fri, Jul 27, 2018, 3:44 PM Alexander Fenster ***@***.***> wrote:
***@***.**** approved this pull request.
@theacodes <https://github.com/theacodes> I'm approving Justin's change
for now but I totally support trying Kokoro - we can switch to using it for
releasing when it's ready.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#109 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUcwLZoMWqyyxcWpSTEkU45SOpDY2rks5uK5fJgaJpZM4Vkwhp>
.
|
@JustinBeckwith can we try Kokoro then? It might be a good small and non-customer-facing project to start with. |
Sure :) @kinwa91 is taking the lead on this for the nodejs side next week. For now I can just #yolo release this. |
No description provided.