Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

chore: use CircleCI for publish #109

Merged
merged 3 commits into from
Aug 6, 2018
Merged

chore: use CircleCI for publish #109

merged 3 commits into from
Aug 6, 2018

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 27, 2018
@JustinBeckwith JustinBeckwith requested review from crwilcox, a team and theacodes and removed request for a team July 27, 2018 22:38
@theacodes
Copy link
Contributor

theacodes commented Jul 27, 2018 via email


branches:
ignore: /.*/
tags: *releases

This comment was marked as spam.

@codecov-io
Copy link

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files          12       12           
  Lines         991      991           
  Branches       60       60           
=======================================
  Hits          936      936           
  Misses         36       36           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044bf76...b5e7a74. Read the comment docs.

- run:
name: Build documentation.
command: npm run docs
- run: echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc

This comment was marked as spam.

This comment was marked as spam.

@JustinBeckwith
Copy link
Contributor Author

Sure! Do you want to take a shot, or should we wait for you to pair up with @kinwa91?

Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theacodes I'm approving Justin's change for now but I totally support trying Kokoro - we can switch to using it for releasing when it's ready.

@theacodes
Copy link
Contributor

theacodes commented Jul 27, 2018 via email

@alexander-fenster
Copy link
Contributor

@JustinBeckwith can we try Kokoro then? It might be a good small and non-customer-facing project to start with.

@JustinBeckwith
Copy link
Contributor Author

Sure :) @kinwa91 is taking the lead on this for the nodejs side next week. For now I can just #yolo release this.

@JustinBeckwith JustinBeckwith merged commit 1e6953c into googleapis:master Aug 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants