Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Cloud SQL for SQL Server Source and Tool #223

Merged
merged 11 commits into from
Jan 23, 2025
Merged

Conversation

duwenxin99
Copy link
Contributor

@duwenxin99 duwenxin99 commented Jan 17, 2025

  1. sql/database provides a Scan()interface to scan query results into typed variables. Therefore we have to create a slice of typed variables (types retrieved from rows.ColumnTypes()) to pass them into Scan(). Using []byte works but makes the printing result different from other tools (e.g [1] instead of %!s(int32=1)]
  2. MS SQL supports both named (e.g @name) and positional args (e.g @p2), so we have to check if the name is contained in the original statement before passing them into db.Query() as either named arg or as values.

@duwenxin99 duwenxin99 requested a review from a team as a code owner January 17, 2025 14:49
@duwenxin99 duwenxin99 closed this Jan 17, 2025
@duwenxin99 duwenxin99 reopened this Jan 17, 2025
Copy link
Contributor

2 similar comments
Copy link
Contributor

Copy link
Contributor

@duwenxin99 duwenxin99 requested a review from kurtisvg January 17, 2025 15:42
Copy link
Contributor

1 similar comment
Copy link
Contributor

Copy link
Contributor

@duwenxin99 duwenxin99 merged commit 9bad952 into main Jan 23, 2025
9 checks passed
@duwenxin99 duwenxin99 deleted the sqlserver branch January 23, 2025 13:21
Copy link
Contributor

🧨 Preview deployments removed.

Yuan325 pushed a commit that referenced this pull request Feb 6, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.1.0](v0.0.5...v0.1.0)
(2025-02-06)


### ⚠ BREAKING CHANGES

* **langchain-sdk:** The SDK for `toolbox-langchain` is now located
[here](https://github.com/googleapis/genai-toolbox-langchain-python).

### Features

* Add Cloud SQL for SQL Server Source and Tool
([#223](#223))
([9bad952](9bad952))
* Add Cloud SQL for MySQL Source and Tool
([#221](#221))
([f1f61d7](f1f61d7))
* Add Dgraph Source and Tool
([#233](#233))
([617cc87](617cc87))
* Add local quickstart
([#232](#232))
([497fb06](497fb06))
* Add user agents for cloud sources
([#244](#244))
([8452f8e](8452f8e))
* Add MySQL Source
([#250](#250))
([378692a](378692a))
* Add MSSQL source
([#255](#255))
([8fca0a9](8fca0a9))


### Bug Fixes

* Auth token verification failure should not throw error immediately
([#234](#234))
([4639cc6](4639cc6))
* Fix typo in postgres test
([#216](#216))
([0c3d12a](0c3d12a))
* **mssql:** Fix mssql tool kind to mssql-sql
([#249](#249))
([1357be2](1357be2))
* **mysql:** Fix mysql tool kind to mysql-sql
([#248](#248))
([669d6b7](669d6b7))
* Schema float type
([#264](#264))
([1702f74](1702f74))
* Typos at test cases
([#265](#265))
([b7c5661](b7c5661))
* Update README and quickstart with the correct async APIs.
([#269](#269))
([21eef2e](21eef2e))
* Update tool invoke to return json
([#266](#266))
([ad58cd5](ad58cd5))

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants