feat(source/alloydb-pg): add configuration for public and private IP #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duwenxin99
approved these changes
Dec 2, 2024
kurtisvg
reviewed
Dec 2, 2024
75ceb1d to
bac5a28
Compare
kurtisvg
approved these changes
Dec 4, 2024
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
duwenxin99
pushed a commit
that referenced
this pull request
Dec 10, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.3](v0.0.2...v0.0.3) (2024-12-10) ### Features * Add --log-level and --logging-format flags ([#97](#97)) ([9a0f618](9a0f618)) * Add options for command ([#110](#110)) ([5c690c5](5c690c5)) * Add Spanner source and tool ([#90](#90)) ([890914a](890914a)) * Add std logger ([#95](#95)) ([6a8feb5](6a8feb5)) * Add structured logger ([#96](#96)) ([5e20417](5e20417)) * **source/alloydb-pg:** Add configuration for public and private IP ([#103](#103)) ([e88ec40](e88ec40)) * **source/cloudsql-pg:** Add configuration for public and private IP ([#114](#114)) ([6479c1d](6479c1d)) ### Bug Fixes * Fix go test workflow ([#84](#84)) ([8c2c373](8c2c373)) * Fix issue causing client session to not close properly while closing SDK. ([#81](#81)) ([9d360e1](9d360e1)) * Fix test cases for ip_type ([#115](#115)) ([5528bec](5528bec)) * Fix the errors showing up after setting up mypy type checker. ([#74](#74)) ([522bbef](522bbef)) * **llamaindex-sdk:** Fix issue causing client session to not close properly while closing SDK. ([#82](#82)) ([fa03376](fa03376)) ### Miscellaneous Chores * Release 0.0.3 ([#122](#122)) ([626e12f](626e12f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to set if their database uses private or public ip. The reason we add this is because the dialer require different initialization with private and public ip.
By default, toolbox will use public ip.