This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
Hide CallSettings as private. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Ruby, a 'private constant' is a constant which will have to be accessed without prefix. So all entties inside of Google::Gax can still access it as-is, but outside the module it can't be accessed as Google::Gax::CallSettings. This affects the tests, so this patch introduced a renaming to toplevel ::CallSettings in a way to avoid violating access of private constant. updates googleapis/gax-python#112
Current coverage is 98.48% (diff: 100%)@@ master #39 diff @@
==========================================
Files 11 11
Lines 1189 1192 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1171 1174 +3
Misses 18 18
Partials 0 0
|
|
Cool, thanks for doing this! LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby, a 'private constant' is a constant which will have
to be accessed without prefix. So all entties inside of
Google::Gax can still access it as-is, but outside the module
it can't be accessed as Google::Gax::CallSettings.
This affects the tests, so this patch introduced a renaming
to toplevel ::CallSettings in a way to avoid violating
access of private constant.
updates googleapis/gax-python#112