Fix retry_codes when empty (#158)

This fixes an issue where timeout wasn't being used. [fixes #71]
googleapis · Apr 10, 2019 · 81758b0 · 81758b0
1 parent 4031be3
commit 81758b0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/google/gax/settings.rb b/lib/google/gax/settings.rb
@@ -83,7 +83,9 @@ def initialize(timeout: 30, retry_options: nil, page_descriptor: nil,
 
       # @return true when it has retry codes.
       def retry_codes?
-        @retry_options && @retry_options.retry_codes
+        @retry_options &&
+          @retry_options.retry_codes &&
+          @retry_options.retry_codes.any?
       end
 
       # @return true when it has valid bundler configuration.

diff --git a/spec/google/gax/api_callable_spec.rb b/spec/google/gax/api_callable_spec.rb
@@ -353,7 +353,7 @@ module Gax
       my_callable = Google::Gax.create_api_call(
         func, CallSettings.new(timeout: 0, retry_options: retry_options)
       )
-      expect { my_callable.call }.to raise_error(Google::Gax::RetryError)
+      expect { my_callable.call }.to raise_error(CustomException)
       expect(call_count).to eq(1)
     end