Updated BatchingSettings default value to Long.MAX_VALUE

gax/src/main/java/com/google/api/gax/batching/v2/BatchingSettings.java

@@ -36,13 +36,13 @@
 /**
  * Represents the batching settings to use for an API method that is capable of batching.
  *
- * <p>Each batching client will have to define their own set of default values for these thresholds,
- * which would be safest behavior for their jobs.
+ * <p>Each batching client must define their own set of default values for these thresholds, which
+ * would be the safest behavior for their jobs.
  *
- * <p>The default instance of this settings are configured to <b>not</b> use batching (i.e. the
- * batch size threshold is 1). This is the safest default behavior, which has meaning in all
- * possible scenarios. Users are expected to configure actual batching thresholds explicitly: the
- * element count, the request bytes count.
+ * <p>The default instance of this settings are configured to accept elements until either of the
+ * threshold reaches {@link Long#MAX_VALUE}) or an explicit call to {@link Batcher#flush()} is made
+ * or the {@link Batcher#close()} is called. Users are expected to configure actual batching
+ * thresholds explicitly: the element count or the request bytes count.
  *
  * <p>Warning: With the incorrect settings, it is possible to cause long periods of dead waiting
  * time.
@@ -57,10 +57,11 @@
  *
  * <ul>
  *   <li><b>Message Count Threshold</b>: Once this many messages are queued, send all of the
- *       messages in a single call. The default value is 1 message.
+ *       messages in a single call, even if the request byte threshold has not been exceed yet. The
+ *       default value is {@link Long#MAX_VALUE} messages.
  *   <li><b>Request Byte Threshold</b>: Once the number of bytes in the batched request reaches this
- *       threshold, send all of the messages in a single call, even if message count thresholds has
- *       not been exceeded yet. The default value is 1 byte.
+ *       threshold, send all of the messages in a single call, even if message count threshold has
+ *       not been exceeded yet. The default value is {@link Long#MAX_VALUE} bytes.
  * </ul>
  *
  * <p>These thresholds are treated as triggers, not as limits. Each threshold is an independent
@@ -79,8 +80,8 @@ public abstract class BatchingSettings {
   /** Get a new builder. */
   public static Builder newBuilder() {
     return new AutoValue_BatchingSettings.Builder()
-        .setElementCountThreshold(1L)
-        .setRequestByteThreshold(1L);
+        .setElementCountThreshold(Long.MAX_VALUE)
+        .setRequestByteThreshold(Long.MAX_VALUE);
   }
 
   /** Get a builder with the same values as this object. */

gax/src/test/java/com/google/api/gax/batching/v2/BatcherImplTest.java

@@ -46,6 +46,7 @@
 import java.util.List;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.Future;
+import org.junit.After;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -70,6 +71,13 @@ public class BatcherImplTest {
           .setElementCountThreshold(1000L)
           .build();
 
+  @After
+  public void tearDown() throws InterruptedException {
+    if (underTest != null) {
+      underTest.close();
+    }
+  }
+
   /** The accumulated results in the test are resolved when {@link Batcher#flush()} is called. */
   @Test
   public void testResultsAreResolvedAfterFlush() throws Exception {