Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Universe domain support for Discovery based libraries. #761

Merged

Conversation

amanda-tarafa
Copy link
Collaborator

This has a dependency on googleapis/google-api-dotnet-client#2675 because we use properties dfined there. This PR's presubmits won't be green until we have merged and released googleapis/google-api-dotnet-client#2675.

@amanda-tarafa amanda-tarafa requested a review from jskeet February 22, 2024 00:35
@amanda-tarafa amanda-tarafa requested a review from a team as a code owner February 22, 2024 00:35
Copy link
Collaborator

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All nice and straightforward :)

@amanda-tarafa amanda-tarafa force-pushed the discovery-universe-domain branch from 6e13c72 to 76330f5 Compare February 22, 2024 18:09
@amanda-tarafa
Copy link
Collaborator Author

I've added a commit updating Google.Apis.Auth to 1.67.0, and I'll merge on green.

@amanda-tarafa amanda-tarafa merged commit b43bae5 into googleapis:main Feb 22, 2024
4 checks passed
@amanda-tarafa amanda-tarafa deleted the discovery-universe-domain branch February 22, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants