Skip to content

Commit

Permalink
fix: Use quotes around extreme int64 values (#1206)
Browse files Browse the repository at this point in the history
JSON numbers are only really expected to be precise as far as IEEE-754 64-bit binary floating point numbers; that means precision is lost for very large integers.
The proto3 JSON specification says that 64-bit integers should be encoded as strings, although numeric values can be parsed.

Fixes #1205
  • Loading branch information
jskeet authored Sep 6, 2022
1 parent fe41478 commit c9d9ff1
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions server/services/compliance_suite.json
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,11 @@
"fSfixed32": 2147483647,
"fUint32": 4294967295,
"fFixed32": 4294967295,
"fInt64": 9223372036854775807,
"fSint64": 9223372036854775807,
"fSfixed64": 9223372036854775807,
"fUint64": 18446744073709551615,
"fFixed64": 18446744073709551615,
"fInt64": "9223372036854775807",
"fSint64": "9223372036854775807",
"fSfixed64": "9223372036854775807",
"fUint64": "18446744073709551615",
"fFixed64": "18446744073709551615",
"fDouble": 1.797693134862315708145274237317043567981e+308,
"fFloat": 3.40282346638528859811704183484516925440e+38,
"fBool": false,
Expand Down

0 comments on commit c9d9ff1

Please sign in to comment.