This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Python 3 compatibility fix #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3, the json library distinguishes between string and bytes types. Ensure that we are passing in string to the json loading function.
geigerj
added a commit
to geigerj/packman
that referenced
this pull request
Aug 10, 2016
geigerj
added a commit
to googleapis/packman
that referenced
this pull request
Aug 10, 2016
* Bump Python GAX version Corresponds to googleapis/gax-python#122 * Also, bump generated package version Some packages are renamed in googleapis/googleapis#76 which is a breaking change. * Bump Python package version Due to googleapis/gapic-generator#367
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3, the json library distinguishes between string and bytes
types. Ensure that we are passing in string to the json loading
function.
This addresses googleapis/google-cloud-python#1944