Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

update php paged map field snippets #3325

Merged

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jan 7, 2021

Update the sample code for mapped fields to include the key for clarity.

@bshaffer bshaffer requested a review from a team as a code owner January 7, 2021 19:14
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2021
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #3325 (c2443d8) into master (7c508c8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3325   +/-   ##
=========================================
  Coverage     87.13%   87.13%           
  Complexity     6120     6120           
=========================================
  Files           495      495           
  Lines         24173    24174    +1     
  Branches       2638     2638           
=========================================
+ Hits          21064    21065    +1     
  Misses         2242     2242           
  Partials        867      867           
Impacted Files Coverage Δ Complexity Δ
...codegen/viewmodel/PageStreamingDescriptorView.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
.../codegen/transformer/PageStreamingTransformer.java 100.00% <100.00%> (ø) 12.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c508c8...c2443d8. Read the comment docs.

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vam-google vam-google merged commit d284392 into googleapis:master Jan 7, 2021
@bshaffer bshaffer deleted the update-php-map-field-snippet branch January 7, 2021 20:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants