-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs build failed in google-analytics-admin
#1916
Labels
type: cleanup
An internal cleanup or hygiene concern.
Comments
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this issue
Jan 25, 2024
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this issue
Feb 1, 2024
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this issue
Feb 4, 2024
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this issue
Feb 21, 2024
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this issue
Mar 4, 2024
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this issue
Jul 8, 2024
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this issue
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See https://github.com/googleapis/googleapis-gen/blob/e7b50944e6637b70bcedd0bab5d666b2f22ef757/google/analytics/admin/v1alpha/google-analytics-admin-v1alpha-py/google/analytics/admin_v1alpha/services/analytics_admin_service/client.py#L10143 where there is an underscore which is not escaped. If a trailing underscore is not escaped then it is interpreted as a hyperlink.
This caused the docs build to fail with
Instead of
It should be
See https://github.com/googleapis/google-cloud-python/actions/runs/7648352502/job/20840980593?pr=12222
We should add a linter rule to check for trailing underscores in proto comments which are not escaped via https://github.com/googleapis/api-linter .
The text was updated successfully, but these errors were encountered: