Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: don't make network request in gRPC context test #970

Merged
merged 1 commit into from
Feb 14, 2019
Merged

test: don't make network request in gRPC context test #970

merged 1 commit into from
Feb 14, 2019

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Feb 13, 2019

We should stop making a request to http://www.google.com/ in our unit test.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2019
@kjin kjin requested a review from a team February 14, 2019 01:32
DominicKramer
DominicKramer approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@DominicKramer DominicKramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just wondering. Why aren't arrow functions being used in this file?

@kjin
Copy link
Contributor Author

kjin commented Feb 14, 2019

@DominicKramer It hasn't been converted to idiomatic TypeScript. This has been an incremental (and rather stalled) process over the last two years.

@kjin kjin merged commit 82e4c24 into googleapis:master Feb 14, 2019
@kjin kjin mentioned this pull request May 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominicKramer DominicKramer DominicKramer approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjin @DominicKramer @googlebot