feat: add contextHeaderBehavior option #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofrobots
reviewed
Nov 1, 2018
src/config.ts
Outdated
| /** | ||
| * Specifies how to use incoming trace context headers. The following options | ||
| * are available: | ||
| * 'default' -- Trace context headers will be respected for incoming |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| * requests that support it. A new trace will be created for requests | ||
| * without trace context headers. | ||
| * 'require' -- Same as default, but traces won't be created for requests | ||
| * without trace context headers. This should not be set for end user-facing |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/config.ts
Outdated
| * services, as this header is usually set by other traced services rather | ||
| * than by users. | ||
| * 'ignore' -- Always ignore trace context headers, so a new trace with a | ||
| * unique ID will be created for every request. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ofrobots
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #879, but also rolls the "experimental"
ignoreContextHeaderoption into a newcontextHeaderOptions.