Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 2.11.0 release proposal #792

Merged
merged 2 commits into from
Jul 2, 2018
Merged

chore: 2.11.0 release proposal #792

merged 2 commits into from
Jul 2, 2018

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Jul 2, 2018

@kjin kjin requested a review from ofrobots July 2, 2018 16:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 2, 2018
ofrobots
ofrobots suggested changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you miss an update to package-lock.json? Here's how I bump the version: npm version --no-git-tag-version {major|minor|patch|specific version} and it takes care of bumping both places.

@kjin
Copy link
Contributor Author

kjin commented Jul 2, 2018

@ofrobots Done. Thanks, I didn't know I needed to update package-lock.json.

ofrobots
ofrobots approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once ci is green.

@kjin kjin merged commit 7025083 into googleapis:master Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrobots ofrobots ofrobots approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjin @ofrobots @googlebot