Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: address cls TODOs #753

Merged
merged 2 commits into from
May 17, 2018
Merged

refactor: address cls TODOs #753

merged 2 commits into from
May 17, 2018

Conversation

kjin
Copy link
Contributor

@kjin kjin commented May 16, 2018 •
edited
Loading

  • Address a TODO to merge common parts of runWithNewContext and bindWithCurrentContext in a single function.
  • Because setContext is only called immediately in runWithNewContext, merge the two into a single function runWithContext. This requires a slight refactor in trace-api which alters the number of stack frames that need to be removed.

Note: Node 8 failure is known; being fixed in #755

@kjin kjin requested review from ofrobots, jinwoo and DominicKramer May 16, 2018 22:57
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 16, 2018
@kjin kjin merged commit ebd33d8 into googleapis:master May 17, 2018
@kjin kjin mentioned this pull request Jun 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrobots ofrobots ofrobots approved these changes

@jinwoo jinwoo Awaiting requested review from jinwoo

@DominicKramer DominicKramer Awaiting requested review from DominicKramer

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjin @ofrobots @googlebot