test: don't use exec to test preloaded modules #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
==========================================
+ Coverage 90.08% 90.15% +0.07%
==========================================
Files 29 29
Lines 1422 1422
Branches 287 287
==========================================
+ Hits 1281 1282 +1
Misses 57 57
+ Partials 84 83 -1
Continue to review full report at Codecov.
|
jinwoo
reviewed
Mar 19, 2018
| private innerLogger = logger({level: logger.LEVELS[PASS_THROUGH_LOG_LEVEL]}); | ||
|
|
||
| private makeLoggerFn(logLevel: keyof Logger): LoggerFunction { | ||
| // TODO(kjin): When we drop support for Node 4, use spread args. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jinwoo
approved these changes
Mar 19, 2018
| private innerLogger = logger({level: logger.LEVELS[PASS_THROUGH_LOG_LEVEL]}); | ||
|
|
||
| private makeLoggerFn(logLevel: keyof Logger): LoggerFunction { | ||
| // TODO(kjin): When we drop support for Node 4, use spread args. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like using
cp.execSyncis a significant source of test flakiness, as the executed command can take more than 4 seconds. The reason for doing this in the past was possibly because it was undesirable to check a global property when all tests ran in a single process. We now run each test in a single process (though if we run tests together again in the future, we will need to ensure that other tests won't interfere with this one).Also, I added a
TestLoggerclass to easily check logger output. This is used in #686 as well.