refactor: ts conversion of plugin loader #568

kjin · 2017-09-26T21:44:16Z

This change turns trace-plugin-loader.ts into TS.

src/trace-plugin-loader.ts

+}
+
+export interface Patch {
+  file?: string;


src/trace-plugin-loader.ts

+  intercept: <T>(module: T, agent: TraceAgent) => T;
+}
+
+export type Plugin = (Patch | Intercept)[];


src/trace-plugin-loader.ts

    if (first !== '@google-cloud/trace-agent') {
      logger_.error('Tracing might not work as ' + first +
            ' was loaded with --require before the trace agent was initialized.');
    }
  }
 }

-function checkPatch(patch) {
+function checkPatch(patch: any) {


src/trace-plugin-loader.ts

+interface InternalPatch<T> extends Patch<T> {
+  file: string;
+  module?: T;
+  patch: (module: T, agent: TraceAgent) => void;


src/trace-plugin-loader.ts

+interface InternalIntercept<T> extends Intercept<T> {
+  file: string;
+  module?: T;
+  intercept: (module: T, agent: TraceAgent) => T;


src/trace-plugin-loader.ts


-var logger_;
+function isPatch<T>(obj: Patch<T> | Intercept<T>): obj is Patch<T> {


src/trace-plugin-loader.ts

+  file: string;
+  patches: {
+    [patchName: string]: {
+      [file: string]: InternalPatch<any> | InternalIntercept<any>;


src/trace-plugin-loader.ts

    if (first !== '@google-cloud/trace-agent') {
      logger_.error('Tracing might not work as ' + first +
            ' was loaded with --require before the trace agent was initialized.');
    }
  }
 }

-function checkPatch(patch) {
+function checkPatch(patch: any) {


src/trace-plugin-loader.ts

    if (!pluginConfig[moduleName]) {
      continue;
    }
-    var agent = new TraceAgent(moduleName);
+    const agent: TraceAgent = new TraceAgent(moduleName);


kjin requested review from ofrobots, matthewloring, gaofanmichael and DominicKramer September 26, 2017 21:44

jmdobry added the in progress label Sep 26, 2017

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2017

ofrobots reviewed Sep 27, 2017

View reviewed changes

kjin force-pushed the ts-pl branch from 5702cfb to 6b39957 Compare September 27, 2017 00:16

ofrobots reviewed Sep 27, 2017

View reviewed changes

kjin added 2 commits September 28, 2017 15:46

refactor: ts conversion of plugin loader

78e66a7

refactor: address comments

f8e43a5

kjin force-pushed the ts-pl branch from b15a69c to f8e43a5 Compare September 28, 2017 22:46

internal interface extends external

e493ccd

ofrobots reviewed Sep 29, 2017

View reviewed changes

refactor: address comments pt 3

65a1563

ofrobots approved these changes Oct 2, 2017

View reviewed changes

kjin merged commit 212f45f into googleapis:master Oct 2, 2017

jmdobry removed the in progress label Oct 2, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: ts conversion of plugin loader #568

refactor: ts conversion of plugin loader #568

kjin commented Sep 26, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.


		var logger_;
		function isPatch<T>(obj: Patch<T> \| Intercept<T>): obj is Patch<T> {

refactor: ts conversion of plugin loader #568

refactor: ts conversion of plugin loader #568

Conversation

kjin commented Sep 26, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.