Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: change constants/trace labels to consts from namespaces; remove JSDoc types #564

Merged
merged 2 commits into from
Sep 25, 2017
Merged

style: change constants/trace labels to consts from namespaces; remove JSDoc types #564

merged 2 commits into from
Sep 25, 2017

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Sep 22, 2017 •
edited
Loading

The style guide forbids namespaces. This commit changes Constants and TraceLabels to plain objects. Also, it removes JSDoc types.

In response to #559 (review)

@kjin kjin requested a review from ofrobots September 22, 2017 22:10
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2017
@kjin kjin mentioned this pull request Sep 22, 2017
Merged
@kjin kjin changed the title style: change constants/trace labels to consts from namespaces style: change constants/trace labels to consts from namespaces; remove JSDoc types Sep 22, 2017
@kjin kjin merged commit 20e69f2 into googleapis:master Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrobots ofrobots ofrobots approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjin @ofrobots @jmdobry @googlebot