Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to config file in docs #1093

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Conversation

maxArturo
Copy link
Contributor

Fixes #1092

  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 2, 2019
Copy link
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kjin kjin merged commit 327032c into googleapis:master Aug 2, 2019
@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #1093 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
- Coverage   94.93%   94.88%   -0.05%     
==========================================
  Files          96       96              
  Lines        6397     6338      -59     
  Branches      498      498              
==========================================
- Hits         6073     6014      -59     
  Misses        166      166              
  Partials      158      158
Impacted Files Coverage Δ
test/web-frameworks/connect.ts 76.92% <0%> (-0.86%) ⬇️
test/test-cls-ah.ts 90% <0%> (-0.7%) ⬇️
test/web-frameworks/hapi17.ts 92.3% <0%> (-0.38%) ⬇️
test/web-frameworks/hapi8_16.ts 90.47% <0%> (-0.23%) ⬇️
test/test-grpc-async-handler.ts 97.01% <0%> (-0.17%) ⬇️
test/test-trace-web-frameworks.ts 98.71% <0%> (-0.12%) ⬇️
test/plugins/test-cls-bluebird.ts 96.72% <0%> (-0.11%) ⬇️
test/test-trace-hapi-tails.ts 97.87% <0%> (-0.09%) ⬇️
test/trace.ts 93.5% <0%> (-0.09%) ⬇️
test/test-config-priority.ts 95.91% <0%> (-0.09%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f5238a...a10e5a6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #1093 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
- Coverage   94.93%   94.88%   -0.05%     
==========================================
  Files          96       96              
  Lines        6397     6338      -59     
  Branches      498      498              
==========================================
- Hits         6073     6014      -59     
  Misses        166      166              
  Partials      158      158
Impacted Files Coverage Δ
test/web-frameworks/connect.ts 76.92% <0%> (-0.86%) ⬇️
test/test-cls-ah.ts 90% <0%> (-0.7%) ⬇️
test/web-frameworks/hapi17.ts 92.3% <0%> (-0.38%) ⬇️
test/web-frameworks/hapi8_16.ts 90.47% <0%> (-0.23%) ⬇️
test/test-grpc-async-handler.ts 97.01% <0%> (-0.17%) ⬇️
test/test-trace-web-frameworks.ts 98.71% <0%> (-0.12%) ⬇️
test/plugins/test-cls-bluebird.ts 96.72% <0%> (-0.11%) ⬇️
test/test-trace-hapi-tails.ts 97.87% <0%> (-0.09%) ⬇️
test/trace.ts 93.5% <0%> (-0.09%) ⬇️
test/test-config-priority.ts 95.91% <0%> (-0.09%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f5238a...a10e5a6. Read the comment docs.

@maxArturo maxArturo deleted the update-docs branch August 4, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: update link to config object in trace API docs
3 participants