Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warn if tracing might not work instead of err #1068

Merged
merged 1 commit into from
Jul 15, 2019
Merged

fix: warn if tracing might not work instead of err #1068

merged 1 commit into from
Jul 15, 2019

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Jul 15, 2019 •
edited
Loading

Fixes #1066

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)

@kjin kjin requested a review from a team July 15, 2019 19:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2019
@kjin kjin force-pushed the log-modules-as-warn branch from 205dcf7 to bc934de Compare July 15, 2019 20:36
@kjin kjin merged commit 8bdd946 into googleapis:master Jul 15, 2019
@release-please release-please bot mentioned this pull request Jun 30, 2022
Merged
@EitanGayor EitanGayor mentioned this pull request May 31, 2024
Open
@EitanGayor EitanGayor mentioned this pull request Jun 22, 2024
Open
This was referenced Jul 17, 2024
Open
Open
@EitanGayor EitanGayor mentioned this pull request Jul 27, 2024
Open
@EitanGayor EitanGayor mentioned this pull request Aug 22, 2024
Open
This was referenced Sep 6, 2024
Open
Open
Open
@EitanGayor EitanGayor mentioned this pull request Sep 14, 2024
Open
@dazdaz dazdaz mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrobots ofrobots ofrobots approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logModulesLoadedBeforeTrace should log a warning not an error, and should have a flag to disable the warning
3 participants
@kjin @ofrobots @googlebot